Remove 1 TODO from ConditionalMutation.java#6463
Merged
Merged
Conversation
Contributor
Author
|
Removes 1 TODO from #2699 |
dlmarion
reviewed
Jul 9, 2026
DomGarguilo
requested changes
Jul 9, 2026
DomGarguilo
reviewed
Jul 9, 2026
Amemeda
changed the title
Member
|
This probably doesn't need to be done and the TODO can just be removed. Updating the public API creates churn that can be disruptive and more to maintain. I can see that it might have been worth doing this if somehow Mutation was altered to keep a reference to the ByteSequence and used that when it was serialized, instead of merely moving the toArray into a constructor, in order to possibly avoid an array copy, but it's not really necessary, and easier to just remove the TODO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
TODO add ByteSequence methods to mutationsfrom line 63 of ConditionalMutation.java with no other modificationsAfter some discussion, the TODO was unnecessary, initial changes in this pr were reverted.
REVERTED CHANGES FOR REFERENCE:
Updated Mutation.java
Updated ConditionalMutation.java
Updated MutationTest.java